Hi Richard and Eli, Thanks for the comments! I just created a new patch with "git format-patch master..mybranch" and it should work now. A svn version is also attached.
Thanks again! Wei -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Richard Smith Sent: Thursday, November 01, 2012 6:27 PM To: Pan, Wei Cc: Eli Friedman; llvm cfe Subject: Re: [cfe-commits] Cilk Plus Extension for Clang --- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -587,6 +587,9 @@ def fobjc_sender_dependent_dispatch : Flag<["-"], "fobjc-sender-dependent-dispat def fobjc : Flag<["-"], "fobjc">, Group<f_Group>; def fomit_frame_pointer : Flag<["-"], "fomit-frame-pointer">, Group<f_Group>; def fopenmp : Flag<["-"], "fopenmp">, Group<f_Group>; +def fcilkplus : Flag<["-"], "fcilkplus">, Group<f_Group>, +Flags<[CC1Option]>, + HelpText<"Enable Cilk Plus extensions">; def fno_cilkplus : +Flag<["-"], "fno-cilkplus">, Group<f_Group>, Flags<[CC1Option]>; Your -cc1 changes only accept -fcilkplus, not -fno-cilkplus, so -fno-cilkplus shouldn't have Flags<[CC1Option]>. On Thu, Nov 1, 2012 at 2:59 PM, Eli Friedman <[email protected]> wrote: > On Thu, Nov 1, 2012 at 10:09 AM, Pan, Wei <[email protected]> wrote: >> Hello All, >> >> Our team would like to add the Cilk Plus extension to Clang for C/C++ >> (http://software.intel.com/file/40297). To meet the requirements that Clang >> sets, we would like to keep our patches small and upstream our patches as >> early as possible. We would appreciate any guidance that the community could >> provide during the course of the implementation. Attached is our first patch >> that enables the Cilk Plus extension option. Looking forward to your review >> and comments! > > This patch doesn't apply against trunk. > > -Eli > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
fcilkplus.patch
Description: fcilkplus.patch
fcilkplus_svn.diff
Description: fcilkplus_svn.diff
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
