On Nov 5, 2012, at 4:09 PM, Matt Beaumont-Gay <[email protected]> wrote:
> On Mon, Nov 5, 2012 at 4:02 PM, Douglas Gregor <[email protected]> wrote: >> >> On Nov 5, 2012, at 3:58 PM, Matt Beaumont-Gay <[email protected]> wrote: >> >>> On Mon, Nov 5, 2012 at 11:45 AM, Douglas Gregor <[email protected]> wrote: >>>> Author: dgregor >>>> Date: Mon Nov 5 13:45:09 2012 >>>> New Revision: 167397 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=167397&view=rev >>>> Log: >>>> Hash the various compiler version, target, preprocessor, and >>>> header-search options into the module hash. We're just using >>>> ADT/Hashing.hpp for this, which isn't as cryptographically strong as >>>> I'd like, but it'll do. >>> >>> Why do you want a cryptographic hash here? >> >> >> Simply because I don't trust that the existing hashes won't produce >> conflicts. > > CityHash passes SMHasher with flying colors: > http://code.google.com/p/smhasher/ > > How much do you care about the possibility of somebody trying to craft > modules with colliding hashes? Not at all. - Doug _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
