Hi;

On Wed, Nov 7, 2012 at 2:15 PM, Chandler Carruth <[email protected]>wrote:

> There is nothing wrong with the patch. =] It looks fine.
>
> However, a test case using sysroot and a fake opensuse tree in the
> Driver tests would be really nice to get before we keep adding new
> versions....
>

I actually wanted to do this to be able to fix
http://llvm.org/bugs/show_bug.cgi?id=12108 but I somehow got distracted.
I'll check this again.


> Also, I wonder if you might rather make this code a bit more smart and
> able to parse out any particular version number in the format open
> suse uses? Then we wouldn't have to update this for each point
> release.
>
>
Could be done easily I guess, I'll have a look at it.

Regards,
ismail
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to