On Sun, Nov 11, 2012 at 12:22 AM, Nico Weber <[email protected]> wrote:
> I was reading Lexer.cpp today and didn't know what BCPLComment means
> -- it's just a regular // comment. Would you mind if that got renamed
> to "LineComment"? That's easier to understand and consistent with
> "BlockComment" which is used for /**/.
Hi Nico,
The name refers to the fact that "//" comments appeared in BCPL. I
knew this fact before so for me this name was not a surprise, but I
think it might be not obvious for someone not familiar with language
history. So I see some value in this renaming.
Regarding the patch: since you are already touching those comments,
please remove duplicated function name from the beginning of the
comment according to the new style advice on Doxygen usage in source
code.
Dmitri
--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
