LGTM.

================
Comment at: lib/AST/StmtDumper.cpp:52
@@ -56,3 +51,3 @@
   public:
-    StmtDumper(SourceManager *sm, raw_ostream &os, unsigned maxDepth)
-      : SM(sm), OS(os), IndentLevel(0), IsFirstLine(true), MaxDepth(maxDepth) {
+    StmtDumper(SourceManager *sm, raw_ostream &os)
+      : SM(sm), OS(os), IndentLevel(0), IsFirstLine(true) {
----------------
Since you are already changing this constructor, could you please adjust sm to 
SM, os to OS to match coding guidelines, and use member initialization list for 
the initialization done in the body?


http://llvm-reviews.chandlerc.com/D98
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to