On Wed, Nov 14, 2012 at 5:27 PM, Hal Finkel <[email protected]> wrote: > ----- Original Message ----- >> From: "Eli Friedman" <[email protected]> >> To: [email protected] >> Sent: Wednesday, November 14, 2012 7:21:59 PM >> Subject: [cfe-commits] r168016 - in /cfe/trunk: lib/AST/ASTContext.cpp >> test/Sema/ppc-bool.c >> >> Author: efriedma >> Date: Wed Nov 14 19:21:59 2012 >> New Revision: 168016 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=168016&view=rev >> Log: >> Fix a trivial bool-related bug I spotted while skimming David Fang's >> current list of powerpc-darwin8 failures. >> >> >> Added: >> cfe/trunk/test/Sema/ppc-bool.c >> Modified: >> cfe/trunk/lib/AST/ASTContext.cpp >> >> Modified: cfe/trunk/lib/AST/ASTContext.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=168016&r1=168015&r2=168016&view=diff >> ============================================================================== >> --- cfe/trunk/lib/AST/ASTContext.cpp (original) >> +++ cfe/trunk/lib/AST/ASTContext.cpp Wed Nov 14 19:21:59 2012 >> @@ -4153,8 +4153,8 @@ >> // At this point, we should have a signed or unsigned integer >> type. >> if (Promotable->isSignedIntegerType()) >> return IntTy; >> - uint64_t PromotableSize = getTypeSize(Promotable); >> - uint64_t IntSize = getTypeSize(IntTy); >> + uint64_t PromotableSize = getIntWidth(Promotable); >> + uint64_t IntSize = getIntWidth(IntTy); > > Should we rename the variables too?
It doesn't matter much, given the only use of these variables is on the next line. -Eli _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
