On Nov 14, 2012, at 5:35 PM, Jordan Rose <[email protected]> wrote:
> > On Nov 14, 2012, at 17:31 , Argyrios Kyrtzidis <[email protected]> wrote: > >> Author: akirtzidis >> Date: Wed Nov 14 19:31:39 2012 >> New Revision: 168017 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=168017&view=rev >> Log: >> [PCH] Reading expressions from attributes should be done using ReadExpr(), >> not ReadExpr(). > > I assume this is supposed to be "ReadExpr(), not ReadSubExpr()"? Yes, it was totally intentional though, to check who is reading my commit logs ;-) > > >> Also add a test case making sure the thread safety attributes work as >> expected >> when they come from a PCH. >> >> Fixes rdar://12584141 & http://llvm.org/PR13982 >> > > >> Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=168017&r1=168016&r2=168017&view=diff >> ============================================================================== >> --- cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (original) >> +++ cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Wed Nov 14 19:31:39 2012 >> @@ -47,7 +47,7 @@ >> .EndsWith("Decl *", "GetLocalDeclAs<" >> + std::string(type, 0, type.size()-1) + ">(F, Record[Idx++])") >> .Case("QualType", "getLocalType(F, Record[Idx++])") >> - .Case("Expr *", "ReadSubExpr()") >> + .Case("Expr *", "ReadExpr(F)") >> .Case("IdentifierInfo *", "GetIdentifierInfo(F, Record, Idx)") >> .Case("SourceLocation", "ReadSourceLocation(F, Record, Idx)") >> .Default("Record[Idx++]"); >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
