LGTM with the following tweak:
+ if (!StaticLibgcc && isAndroid)
+ CmdArgs.push_back("-ldl");
I would start with the 'isAndroid' condition just to make it more
clear that this is an android-specific hack. I would also add a
comment similar to your original email. It is really important to
document this type of surprising constraint in the source, not just in
the email. ;]
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
