On Wed, Nov 21, 2012 at 3:50 PM, Chandler Carruth <[email protected]>wrote:
> On Wed, Nov 21, 2012 at 3:46 PM, Matt Beaumont-Gay <[email protected]> > wrote: > > On Wed, Nov 21, 2012 at 3:40 PM, Chandler Carruth <[email protected]> > wrote: > >> Modified: cfe/trunk/lib/Driver/ToolChains.cpp > >> URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=168473&r1=168472&r2=168473&view=diff > >> > ============================================================================== > >> --- cfe/trunk/lib/Driver/ToolChains.cpp (original) > >> +++ cfe/trunk/lib/Driver/ToolChains.cpp Wed Nov 21 17:40:23 2012 > >> @@ -2230,10 +2230,15 @@ > >> return *T; > >> } > >> > >> -void Linux::addClangTargetOptions(ArgStringList &CC1Args) const { > >> +void Linux::addClangTargetOptions(const ArgList &DriverArgs, > >> + ArgStringList &CC1Args) const { > >> const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion(); > >> - if (V >= Generic_GCC::GCCVersion::Parse("4.7.0") || > >> - getTriple().getEnvironment() == llvm::Triple::Android) > >> + bool UseInitArrayDefault > >> + = V >= Generic_GCC::GCCVersion::Parse("4.7.0") || > > > > Is the preferred style really to put the '=' on the next line like this? > > It's a common style, I think trying to distinguish between an operator > like == and the initializer for a variable... > > I don't actually have any preference here. Doug once told me to do it > like this, and I've done so as consistently as I can since... > > Huh. I've always done it the other way. -eric
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
