Hi, I think that the current test for always_inline can be improved by also checking that -fno-inline does not impact the always_inline attribute.
Ok to commit? Thanks, Sebastian -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>From f73da2b102db4dc92b020e5cc8055c67d84ed554 Mon Sep 17 00:00:00 2001 From: Sebastian Pop <[email protected]> Date: Mon, 26 Nov 2012 13:26:54 -0600 Subject: [PATCH] check that always_inline attribute works with -fno-inline --- test/CodeGen/always-inline.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/test/CodeGen/always-inline.c b/test/CodeGen/always-inline.c index dc74be5..c8ccd4f 100644 --- a/test/CodeGen/always-inline.c +++ b/test/CodeGen/always-inline.c @@ -1,4 +1,5 @@ // RUN: %clang_cc1 -emit-llvm %s -o - | grep call | not grep foo +// RUN: %clang_cc1 -fno-inline -emit-llvm %s -o - | grep call | not grep foo void bar() { } -- 1.7.6.4
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
