Yep. That's what I meant. :) Noticed the testcases changed between revisions?
-eric On Thu, Nov 29, 2012 at 2:45 PM, Michael Ilseman <[email protected]> wrote: > > On Nov 29, 2012, at 2:29 PM, Eli Friedman <[email protected]> wrote: > > > On Thu, Nov 29, 2012 at 2:18 PM, Michael Ilseman <[email protected]> > wrote: > >> > >> On Nov 29, 2012, at 2:17 PM, Eric Christopher <[email protected]> > wrote: > >> > >> On Thu, Nov 29, 2012 at 2:12 PM, Michael Ilseman <[email protected]> > wrote: > >>> > >>> Sorry, fixed patch attached > >>> > >> > >> Testcases maybe in the patch next time? :) > >> > >> > >> There were two new test cases attached to the original email. > > > > We generally prefer the patch to exactly match what you intend to > > commit; this means you should include the testcases within the patch > > file. > > > > Oh, I understand what Eric meant now. Sorry about that! Here's an > all-included patch. > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
