On Nov 30, 2012, at 11:32 AM, Manuel Klimek <[email protected]> wrote:
> On Fri, Nov 30, 2012 at 8:18 PM, Douglas Gregor <[email protected]> wrote:
>
> On Nov 29, 2012, at 1:16 PM, Daniel Jasper <[email protected]> wrote:
>
> >
> > Ping.
> >
> > Also, we are continuing the development on
> > https://github.com/djasper/clang/tree/format, but I am currently not
> > updating this patch in fear of prolonging the review even more. It has
> > reached a stage where it starts improving my workflow thanks to a little
> > vim integration I have hacked together ...
>
> A few questions and comments on the patch, but IMO I'd rather see this go
> into the main Clang tree soon and get hacked on there, since it looks like
> we're moving in the right direction and it's obviously functionality we want
> in the core.
>
> +/// \brief A character range of source code.
> +struct CodeRange {
> + CodeRange(unsigned Offset, unsigned Length)
> + : Offset(Offset), Length(Length) {}
> +
> + unsigned Offset;
> + unsigned Length;
> +};
>
> Why isn't this a SourceRange or CharSourceRange?
>
> This would put the burden on the client to do the "Offset+Length ->
> SourceRange" translation. But you're right, in this case that might be the
> right trade-off…
This seems like a *very* small burden to eliminate two similar-but-not-the-same
concepts with disturbingly similar names. It's CharSourceRange you want, though.
> Once the first version is checked in, we'll next check a tool into
> clang-extra-tools plus some nice vi integration with which you can run it
> over code snippets (or full files). Daniel actually has built that, and the
> fact that this is already surprisingly useful has accelerated development
> here somewhat :)
Okay!
- Doug_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
