I see. Thanks for the explanation! Michael On Mon, Dec 3, 2012 at 9:38 AM, Jordan Rose <[email protected]> wrote:
> Some of them are primarily testing the caret fixits, but you're right that > the parseable fixits don't actually *prevent* you from testing the caret > fixits. On the other hand, until recently FileCheck didn't have a way to > specify relative line numbers, meaning that adding a new line at the top of > the file would change all of the parseable fixits (unless matched with > wildcards). > > Going forward we should probably endeavour to test the parseable fixits > for every test where we're not *just* testing caret fixit emission. > > Jordan > > > On Dec 1, 2012, at 21:05 , Michael Han <[email protected]> wrote: > > Hi Dmitri, > > Thanks! Attach updated patch. > > I noticed that not all test cases under clang/test/FixIt use > "-fdiagnostics-parseable-fixits". Is there a reason why not all FixIt test > cases use this option? > > Cheers > Michael > > On Sat, Dec 1, 2012 at 5:21 AM, Dmitri Gribenko <[email protected]>wrote: > >> On Sat, Dec 1, 2012 at 6:30 AM, Michael Han <[email protected]> >> wrote: >> > This patch adds two FixIts to parser when parsing C++11 attributes >> appertain >> > to class specifier. It is a following up patch of a previous patch [1]. >> > >> > Please review, thanks! >> >> Hello Michael, >> >> FixIts can be tested with -fdiagnostics-parseable-fixits (search the >> testsuite for this option to find examples). >> >> Dmitri >> >> -- >> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if >> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ >> > > <fixit.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
