Looks good in general, but there are a few nitpicks:
================
Comment at: lib/AST/StmtDumper.cpp:293
@@ +292,3 @@
+
+ if (DeclStmt* DS = dyn_cast<DeclStmt>(S)) {
+ VisitDeclStmt(DS);
----------------
Put the star to the variable, please (see
http://llvm.org/docs/CodingStandards.html):
DeclStmt *DS
================
Comment at: lib/AST/StmtDumper.cpp:299
@@ +298,3 @@
+ Visit(S);
+ for (Stmt::child_range CI = S->children(); CI; CI++)
+ dumpStmt(*CI);
----------------
Please use ++CI instead of CI++
================
Comment at: lib/AST/StmtDumper.cpp:518
@@ -520,3 +517,3 @@
DumpDeclRef(i->getVariable());
- if (i->hasCopyExpr()) DumpSubTree(i->getCopyExpr());
+ if (i->hasCopyExpr()) dumpStmt(i->getCopyExpr());
}
----------------
Please break the line.
================
Comment at: lib/AST/StmtDumper.cpp:89
@@ -105,8 +88,3 @@
}
void DumpDeclRef(Decl *node);
void DumpValueKind(ExprValueKind K) {
----------------
As long as you rename methods in this class, please make Dump* methods
lowercase.
http://llvm-reviews.chandlerc.com/D156
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
