> I have reviewed this patch (over three iterations) and am happy with it.  I'd 
> be happy to commit it if none of the driver people want to give it another 
> look.

You pass -mfpu=softvfp even when you have a hard float abi
(llvm::Triple::GNUEABIHF), no? Is that really correct?

test/Misc/freebsd-arm-size_t.c:

Nit: Use "clang -cc1" and -verify instead of "clang -Werror".

Please make sure that you have a test where  -mfpu=softvfp shows up.
Please add a test with the hard float environment.

> David
> (With my FreeBSD/toolchain and Clang committer hats on)

Cheers,
Rafael
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to