Applied in r169964, thank you!
2012/12/12 김보곤 <[email protected]> > Hello, > > > > It works fine when I changed my code like you recommended > > I have made the patch again. > > Thank you for your advice > > > > ------- *Original Message* ------- > > *Sender* : NAKAMURA Takumi<[email protected]> > > *Date* : 2012-12-11 18:38 (GMT+09:00) > > *Title* : Re: [cfe-commits] [Patch] Support multiple path of > COMPILER_PATH env on windows platform > > > Hello, Kim. > > Thank you to work on Win32. > > Could you use llvm::sys::PathSeparator there? Please confirm in your > environment. > > FYI, I heard llvm::sys might be deprecated in future. That said, I am not > sure when it done. > We may use llvm::sys for now. > > --- lib/Driver/Driver.cpp (revision 169719) > +++ lib/Driver/Driver.cpp (working copy) > @@ -238,7 +238,11 @@ > if (char *env = ::getenv("COMPILER_PATH")) { > StringRef CompilerPath = env; > while (!CompilerPath.empty()) { > - std::pair<StringRef, StringRef> Split = CompilerPath.split(':'); > +#ifdef LLVM_ON_WIN32 > + std::pair<StringRef, StringRef> Split = CompilerPath.split(';'); > +#else > + std::pair<StringRef, StringRef> Split = CompilerPath.split(':'); > +#endif > > Please be aware of indentation. We prefer to follow the style in existing > code. > http://llvm.org/docs/CodingStandards.html#golden-rule > > ...Takumi > > > > 2012/12/11 김보곤 <[email protected]> > >> Hello, everyone. >> >> >> >> The COMPILER_PATH environment seperator is semicolon on windows as colon >> on linux >> >> >> >> To support multiple path of COMPILER_PATH env, change the seperator to >> semicolon for windows platform >> >> >> >> P.S >> >> This is my first contribution. Please let me know if there is any mistakes >> >> >> >> ** >> >> *김 보 곤 (Bogon Kim)* >> >> >> >> *Platform R&D Group* >> >> *Mobile Communication Division* >> >> *Samsung Electronics.Co.,LTD* >> >> *TEL 82 - 31 - 301 - 2814* >> >> *Mobile 82 - 11 - 881 - 8458* >> >> *E-mail [email protected]* >> >> *With passion and confidence(WPAC)* >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> > > > > > ** > > *김 보 곤 (Bogon Kim)* > > > > *Platform R&D Group* > > *Mobile Communication Division* > > *Samsung Electronics.Co.,LTD* > > *TEL 82 - 31 - 301 - 2814* > > *Mobile 82 - 11 - 881 - 8458* > > *E-mail [email protected]* > > *With passion and confidence(WPAC)* > > > > > > > > > > > > > > > > > > > > > > > >
<<201212121450643_7EUABGFC.gif>>
<<201212121450571_QKNMBDIF.gif>>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
