On Dec 18, 2012, at 3:23 PM, Dmitri Gribenko <[email protected]> wrote:
> Hi Fariborz, Previous comments is in r170478. > >> >> + llvm::IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts; >> + llvm::IntrusiveRefCntPtr<DiagnosticsEngine> Diagnostics; >> + FileManager Files; >> + SourceManager Sources; > > We already have a SourceManager. Why not reuse it? (I'm just > guessing -- maybe creating an in-memory file is permanent for the > SourceManager?) I am not sure. Others, Doug, may want to comment. - Thanks, Fariborz _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
