On Mon, Dec 17, 2012 at 2:55 PM, Argyrios Kyrtzidis <[email protected]> wrote: > On Dec 17, 2012, at 12:51 PM, David Blaikie <[email protected]> wrote: > >> On Mon, Dec 17, 2012 at 12:10 PM, Argyrios Kyrtzidis <[email protected]> >> wrote: >>> Author: akirtzidis >>> Date: Mon Dec 17 14:10:50 2012 >>> New Revision: 170365 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=170365&view=rev >>> Log: >>> Just use begin()/end() instead of "&Vector[0], &Vector[0]+Vector.size()". >>> >>> No functionality change. >>> >>> Modified: >>> cfe/trunk/include/clang/AST/DeclContextInternals.h >>> >>> Modified: cfe/trunk/include/clang/AST/DeclContextInternals.h >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclContextInternals.h?rev=170365&r1=170364&r2=170365&view=diff >>> ============================================================================== >>> --- cfe/trunk/include/clang/AST/DeclContextInternals.h (original) >>> +++ cfe/trunk/include/clang/AST/DeclContextInternals.h Mon Dec 17 14:10:50 >>> 2012 >>> @@ -117,7 +117,7 @@ >>> DeclsTy &Vector = *getAsVector(); >>> >>> // Otherwise, we have a range result. >>> - return DeclContext::lookup_result(&Vector[0], >>> &Vector[0]+Vector.size()); >>> + return DeclContext::lookup_result(Vector.begin(), Vector.end()); >> >> Perhaps change/update this API to take an ArrayRef instead? > > DeclContextLookupResult (which DeclContext::lookup_result is a typedef of) > should probably be changed to a typedef of an ArrayRef, I think.
Agreed. r170482. Thanks, - David > >> >>> } >>> >>> /// HandleRedeclaration - If this is a redeclaration of an existing decl, >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
