Hi Quentin, On Dec 19, 2012, at 11:14 AM, Quentin Neill <[email protected]> wrote:
> Reposting the (*untested*) patch with correct email address... > > -- > Quentin Neill > [email protected] > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation > > > -----Original Message----- > From: Quentin Neill [mailto:[email protected]] > Sent: Wednesday, December 19, 2012 1:08 PM > To: 'Quentin Colombet'; 'Eli Friedman' > Cc: 'llvm cfe' > Subject: RE: [cfe-commits] [PATCH] Add ARM cortex-a5 subtarget > > Hi Quentin, > > Shouldn't the cortex-a5 change be (possibly) added to every cortex-a8 > occurrence, as in the (*untested*) patch attached? That would make sense. However, as it is, your patch is not compiling because the Cases method is taking up to 6 arguments. You have to split your Cases call in lib/Driver/ToolChains.cpp:123. - Quentin > -- > Quentin Neill > [email protected] > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation > > "Hi Quentin" <- I don't get to type that very often :) > > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Quentin Colombet > Sent: Thursday, November 29, 2012 4:34 PM > To: Eli Friedman > Cc: llvm cfe > Subject: Re: [cfe-commits] [PATCH] Add ARM cortex-a5 subtarget > > Hi Eli, > > Thanks for the review. > > Regarding your question, I have no idea but there is a FIXME in the source > about that. > > Quentin > > > On Nov 29, 2012, at 2:27 PM, Eli Friedman <[email protected]> wrote: > >> On Thu, Nov 29, 2012 at 1:14 PM, Quentin Colombet <[email protected]> > wrote: >>> Hello, >>> >>> Here is a patch proposal to enable the newly added cortex-a5 ARM sub > target (see llvm commit revision 168933). >>> The patch consists in adding the cortex-a5 in the ARMTargetInfo and in > the Driver. >>> >>> Thanks for the reviews. >> >> General question: is there any way we can use TableGen to autogenerate >> this stuff? >> >> Patch looks fine. >> >> -Eli > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > <0001-Finish-adding-ARM-cortex-a5-subtarget.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
