Looks good. Inlined, see some rephrasing for your consideration
================ Comment at: docs/UsersManual.rst:931 @@ +930,3 @@ + - ``-fsanitize-memory-track-origins``: Enables origin tracking in + MemorySanitizer. Adds a second stack trace to MemorySanitizer + reports pointing to the allocation the uninitialized bits came ---------------- Adds a second section ...? ================ Comment at: docs/UsersManual.rst:932 @@ +931,3 @@ + MemorySanitizer. Adds a second stack trace to MemorySanitizer + reports pointing to the allocation the uninitialized bits came + from. Slows down execution by additional 1.5x-2x. ---------------- to the heap or stack allocation that created uninitialized bits ? ================ Comment at: docs/MemorySanitizer.rst:28 @@ +27,3 @@ +executable, so make sure to use ``clang`` (not ``ld``) for the final +link step. When linking shared libraries, the MEmorySanitizer run-time +is not linked, so ``-Wl,-z,defs`` may cause link errors (don't use it ---------------- MemorySanitizer (not MEm..) ================ Comment at: docs/MemorySanitizer.rst:129 @@ +128,3 @@ +instrumentation to avoid false positives due to uninstrumented code. +Essentially, all it does is mark the memory that is writted to from +uninstrumented libraries as fully uninitialized. See ---------------- It simply marks memory written from ... http://llvm-reviews.chandlerc.com/D228 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
