Hi Anton,
Dealing with the read_only/write_only attributes is not part of this patch, but
I plan to address that soon too.
About the address spaces, the current implementation supplies a base class
(CGOpenCLRuntime), that should be overloaded by the specific OpenCL
implementation. I can add address spaces to the different types, if it's agreed
by everyone.
Thanks
Guy
-----Original Message-----
From: Anton Lokhmotov [mailto:[email protected]]
Sent: Thursday, December 20, 2012 15:30
To: Benyei, Guy
Cc: Tanya Lattner; Richard Smith; [email protected]
Subject: Re: [PATCH] OpenCL images as builtin types
Hi Guy,
Good to see progress on this front! As I understand, you resubmitted your
earlier patch [1], where you fixed most of the comments from Tanya, Richard and
myself. However, you did not address my comments re the address spaces of
images (global) e.g.:
case BuiltinType::OCLImage1d:
const unsigned AddrSpace =
Context.getTargetAddressSpace(LangAS::opencl_global);
return llvm::PointerType::get(llvm::StructType::create(
CGM.getLLVMContext(), "opencl.image1d_t"),
AddrSpace);
...
Also, what's your plan to dealing with the image access qualifiers:
read_only and write_only?
Cheers,
Anton.
[1] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-November/025557.html
[2] http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-October/025337.html
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
