On Dec 20, 2012, at 2:48 PM, John McCall <[email protected]> wrote: > On Dec 20, 2012, at 2:31 PM, Ted Kremenek <[email protected]> wrote: >> Author: kremenek >> Date: Thu Dec 20 16:31:27 2012 >> New Revision: 170777 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=170777&view=rev >> Log: >> Revert "Warn if a __weak variable is initialized with an Objective-C object >> literal." >> >> Per code feedback, I want to see if there is a more general way to do this. > > When you add it back, please add the code to Sema::checkUnsafeAssigns, > which is where the existing warning about code like this is implemented: > __weak id x = [NSString new]; > > John.
Right. Both you and Jordan pointed this out. Seems like the logical place to put it. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
