LGTM since the test is good and dgregor was fine with the patch proper.
On 24 December 2012 14:21, Benyei, Guy <[email protected]> wrote: > > Hi, > > Added an additional test to check that the calling convention occurs in > the IR. > > Please review. > > > > Thanks > > Guy Benyei > > > > > > From: Douglas Gregor [mailto:[email protected]] > Sent: Thursday, December 20, 2012 23:46 > To: Benyei, Guy > Cc: [email protected] > Subject: Re: [cfe-commits] [PATCH] Add intel_ocl_bicc calling convention > to Clang > > > > > > On Dec 19, 2012, at 6:23 AM, "Benyei, Guy" <[email protected]> wrote: > > > > Hi all, > > Attached a patch that adds intel_ocl_bicc calling convention as a function > attribute to Clang. > > This calling convention already exists in LLVM, and it was added in order > to support the Intel OpenCL built-in library. > > > > > > Generally looks fine, but I don't see a test that this attribute survives > down to LLVM IR. > > > > - Doug > > > > Please review > > > > Thanks > > Guy Benyei > > <image001.png> > > > > <inteloclbicc.patch> > > --------------------------------------------------------------------- > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > --------------------------------------------------------------------- > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
