Ping? Any wrong on this patch? Or any suggestion? This patch fix array exception destruction bug, and w/o broking any test.
Thanks. > -----Original Message----- > From: WenHan Gu (谷汶翰) > Sent: Tuesday, December 18, 2012 10:47 AM > To: 'Eli Friedman' > Cc: John McCall; [email protected]; [email protected]; > [email protected] > Subject: RE: [PATCH] Fix PR14514: Call destructor automatically after a throw > > I move the logic to caller, which won't push cleanup if not destruct-able. > R4 attached. > > > -----Original Message----- > > From: Eli Friedman [mailto:[email protected]] > > Sent: Tuesday, December 18, 2012 10:15 AM > > To: WenHan Gu (谷汶翰) > > Cc: John McCall; [email protected]; [email protected]; > > [email protected] > > Subject: Re: [PATCH] Fix PR14514: Call destructor automatically after > > a throw > > > > On Mon, Dec 17, 2012 at 5:53 PM, WenHan Gu (谷汶翰) > > <[email protected]> wrote: > > > OK, thanks. > > > Patch set 3 uploaded. > > > > @@ -1367,6 +1367,9 @@ static void > > emitPartialArrayDestroy(CodeGenFunction &CGF, > > type = arrayType->getElementType(); > > } > > > > + if (type.isDestructedType() == QualType::DK_none) > > + return; // Check again for nest array > > + > > > > That doesn't help; you're still pushing the cleanup. > > > > -Eli ************* Email Confidentiality Notice ******************** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!
PR14514_r4.patch
Description: PR14514_r4.patch
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
