Can you please send me the exact patch you tried to upload, then I'll repro and file a bug with upstream #phab.
Thanks! /Manuel On Tue, Jan 8, 2013 at 5:24 PM, David Blaikie <[email protected]> wrote: > +Manuel who's been doing the work to bring Phab up for code review > here, in case he has some ideas > > On Tue, Jan 8, 2013 at 8:20 AM, Tim Northover <[email protected]> > wrote: > > On Monday 07 Jan 2013 16:52:38 Tim Northover wrote: > >> On Monday 07 Jan 2013 16:44:11 David Blaikie wrote: > >> > On Mon, Jan 7, 2013 at 6:04 AM, Tim Northover <[email protected]> > >> > wrote: Perhaps using the Phabricator code review ( > >> > http://llvm-reviews.chandlerc.com/ ) would avoid some of the pain of > >> > sending large patch attachments to the list repeatedly. > >> > >> Certainly a good thing to try. I'll try using that for the updated patch > >> and see how things go. > > > > Well, that was a short-lived attempt. The Clang patch is uploadable, but > the > > LLVM one gives an error message: > > > > Diff Parse Exception: Expected a hunk header, like 'Index: > /path/to/file.ext' > > (svn), 'Property changes on: /path/to/file.ext' (svn properties), 'commit > > 59bcc3ad6775562f845953cf01624225' (git show), 'diff --git' (git diff), > '--- > > filename' (unified diff), or 'diff -r' (hg diff or patch). > > > > >>> 1 > > > > The file does begin with "diff --git"; I'm assuming it might be just too > big. > > > > Tim. > > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
