Obviously iterative refinement is fine, and this isn't a commit blocker, but categories and protocols conventionally have spaces before and after the parens / angle brackets.
(references: http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW2 http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithProtocols/WorkingwithProtocols.html#//apple_ref/doc/uid/TP40011210-CH11-SW1 ) Also, can you add some test cases with multiple methods, just in case? Thanks for doing this! Jordan On Jan 9, 2013, at 9:44 , Nico Weber <[email protected]> wrote: > Hi, > > the attached patch adds formatting for @interface. There's likely some > polishing left to do, but it's a huge step up from the current > behavior (putting everything in an @interface on a single line if > there are no ivars). Ok to commit? > > Even if you don't know Objective-C, looking at the included tests > should be enough to give you an idea of what's going on. > > Nico > <clang-format-objcinterface.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
