On Saturday 12 January 2013 11:15:15 Nico Weber wrote: > On Sat, Jan 12, 2013 at 10:37 AM, Arnaud A. de Grandmaison > > <[email protected]> wrote: > > Author: aadg > > Date: Sat Jan 12 12:37:52 2013 > > New Revision: 172321 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=172321&view=rev > > Log: > > Fix spurious output in JSONCompilationDatabase > > Is there a bug or test for this? Without this, a few months down the > road it's going to be difficult to figure out why this change was > made. >
This can not be called a bug, and I do not think a test is worth it : this patch basically removes a debug "printf" to stdout, This does not affect functionality, but an undesirable side effect for library users. > > Modified: > > cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp > > > > Modified: cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/JSONCompilation > > Database.cpp?rev=172321&r1=172320&r2=172321&view=diff > > ========================================================================= > > ===== --- cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp (original) > > +++ cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp Sat Jan 12 12:37:52 > > 2013 @@ -167,12 +167,8 @@ > > > > std::string Error; > > llvm::raw_string_ostream ES(Error); > > StringRef Match = MatchTrie.findEquivalent(NativeFilePath.str(), ES); > > > > - if (Match.empty()) { > > - if (Error.empty()) > > - Error = "No match found."; > > - llvm::outs() << Error << "\n"; > > + if (Match.empty()) > > > > return std::vector<CompileCommand>(); > > > > - } > > > > llvm::StringMap< std::vector<CompileCommandRef> >::const_iterator > > > > CommandsRefI = IndexByFile.find(Match); > > > > if (CommandsRefI == IndexByFile.end()) > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
