On Mon, Jan 14, 2013 at 2:19 PM, Robinson, Paul <[email protected]> wrote: > Fixed debuginfo-test\static-member.cpp as requested. > New diff attached (just that one). > > Ran GDB test suite 7.2 (what I have) with trunk and with my patch. > (Someday I'll pick up the one you guys are using....)
You should just be able to check it out from llvm.org/svn/llvm-project/clang-tests-external/trunk then configure and: make check RUNTESTFLAGS="CXX_FOR_TARGET='path/to/clang++' CC_FOR_TARGET='path/to/clang' CFLAGS_FOR_TARGET='-w -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-limit-debug-info'" FORCE_PARALLEL=1 to reproduce the same process as the buildbot here: http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75 > Fixed 7 FAIL and 1 UNSUPPORTED. > > Please commit for me. > Thanks! > --paulr > > > > From: Eric Christopher [[email protected]] > Sent: Thursday, January 10, 2013 2:31 PM > To: Robinson, Paul > Cc: [email protected] > Subject: Re: [cfe-commits] [PATCH] PR14471: Debug info for static data > members (Clang part) > > > Hi Paul, > > > Looking much better. Few comments: > > > +// RUN: %clangxx -O0 -g %s -c -o %t.o > +// RUN: %clangxx %t.o -o %t.out > +// RUN: %test_debuginfo %s %t.out > + > > > Can probably do the compile and link in one line if we're not using the > temporary .o file. > > > +// DEBUGGER: delete breakpoints > +// DEBUGGER: break main > +// DEBUGGER: r > +// DEBUGGER: n > +// DEBUGGER: p instance_C > +// CHECK: $1 = {static a = 4, static b = {{.*}}, static c = 15, d = {{.*}}} > + > > > Might also want to ptype C as well? > > > +class C > +{ > > > Formatting in the testcase if you don't mind. > > > Otherwise, much nicer! Same comments as the llvm one :) > > > -eric > > > > On Tue, Jan 8, 2013 at 5:16 PM, Robinson, Paul <[email protected]> > wrote: > > New and improved, refreshed and invigorated patch for PR14471/14734. > > - CGDebugInfo::CollectRecordFields() decomposed with 3 new helpers. > - The "fieldNo - 1" is gone, thanks to the refactoring. > - Commentary about the field counting added. > - getStaticDataMemberDeclaration() checks the decl before doing the search. > I hope that was everything! > > --paulr > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
