David wrote: > Sure enough. Is there anything we can do to mitigate the duplicated > effort/code, then?
I think in this case there's not much to worry about. I can't really think of any other transforms cpp11-migrate might perform that relate to warnings as clearly as nullptr does. Also, I'm not really familiar with how fixits are implemented but if it's with AST Matchers in any way, the matcher employed by use-nullptr is pretty trivial. IMO, since this seems like a unique case and the amount of code involved is small that duplication isn't a big concern in general with cpp11-migrate. We should definitely keep an eye out though in case other situations crop up. I think the only way to handle that is to be clear about which transforms are being considered for implementation so duplication can be spotted early. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
