On the clang side, it seems messy and error-prone to distribute the checking for blacklisting across all the callers of EmitCheck, but I understand that you're trying to avoid generating the check condition for blacklisted functions. Maybe we could make a separate struct containing just the Sanitize* flags, and in the CodeGenFunction constructor bind a reference to either the global set of flags or a set of all-false flags, depending on whether we're blacklisted? This would also make it easier to blacklist specific sanitizers in specific functions later.
On Wed, Jan 16, 2013 at 12:08 PM, Will Dietz <[email protected]> wrote: > Minor touchup to clang patch, thanks! > > ~Will > > On Wed, Jan 16, 2013 at 11:37 AM, Will Dietz <[email protected]> wrote: >> Attached are two patches. >> >> First applies to clang and uses the blacklist to avoid instrumenting >> the source files or functions specified. Lit test included. >> >> The other is a small change to llvm to make the "Blacklist" class >> visible to Clang. Not sure I understand the header organization >> system well enough, let me know if it belongs elsewhere. >> >> Thanks! >> >> ~Will > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
