On Jan 17, 2013, at 2:23 AM, NAKAMURA Takumi <[email protected]> wrote:

> Argyrios, please confirm if my change would make sense.

LGTM.

> 
> ...Takumi
> 
> 2013/1/17 NAKAMURA Takumi <[email protected]>:
>> Author: chapuni
>> Date: Thu Jan 17 01:27:55 2013
>> New Revision: 172705
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=172705&view=rev
>> Log:
>> clang/test/Index/code-completion-skip-bodies.cpp: Check stdout and stderr 
>> individually, rather than mixed output of stdout and stderr with 2>&1.
>> 
>> XFAIL(s) are removed.
>> 
>> Modified:
>>    cfe/trunk/test/Index/code-completion-skip-bodies.cpp
>> 
>> Modified: cfe/trunk/test/Index/code-completion-skip-bodies.cpp
>> URL: 
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/code-completion-skip-bodies.cpp?rev=172705&r1=172704&r2=172705&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Index/code-completion-skip-bodies.cpp (original)
>> +++ cfe/trunk/test/Index/code-completion-skip-bodies.cpp Thu Jan 17 01:27:55 
>> 2013
>> @@ -11,10 +11,10 @@
>>   s->x = 0;
>> }
>> 
>> -// RUN: c-index-test -code-completion-at=%s:11:6 %s 2>&1 | FileCheck %s
>> -// CHECK-NOT: error: use of undeclared identifier 'undeclared1'
>> -// CHECK: error: use of undeclared identifier 'undeclared2'
>> -// CHECK: FieldDecl:{ResultType int}{TypedText x}
>> +// RUN: c-index-test -code-completion-at=%s:11:6 %s 2> %t.stderr | 
>> FileCheck %s --check-prefix=STDOUT
>> +// RUN: FileCheck --input-file=%t.stderr --check-prefix=STDERR %s
>> 
>> -// FIXME: Investigating
>> -// XFAIL: cygwin,mingw32,win32
>> +// STDOUT: FieldDecl:{ResultType int}{TypedText x}
>> +
>> +// STDERR-NOT: error: use of undeclared identifier 'undeclared1'
>> +// STDERR:     error: use of undeclared identifier 'undeclared2'
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> [email protected]
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to