On Thu, Jan 17, 2013 at 02:28:03PM -0800, Anna Zaks wrote: > Hi Branden, > The naming of the kinds is not very consistent, so I suggest renaming: > PSK_InvalidatedRegionDirectly, -> PSK_DirectEscapeOnCall, > PSK_InvalidatedRegionIndirectly, -> PSK_DirectEscapeOnCall, > PSK_InvalidatedRegionOther -> PSKEscapeOther > > In the checkers, I'd use the Kind instead of the Call parameter to be more > explicit: > if (Call && > with > if ((Kind == PSK_DirectEscapeOnCall || Kind == PSK_DirectEscapeOnCall) &&
This looks quite strange, are you really meaning to map both PSK_InvalidatedRegionDirectly and PSK_InvalidatedRegionIndirectly to PSK_DirectEscapeOnCall? Smells like a lost In-, particularly when you look at the suggested condition: (Kind == PSK_DirectEscapeOnCall || Kind == PSK_DirectEscapeOnCall) -- Lars Viklund | [email protected] _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
