This is converging, so I'm putting it up on Phabricator for better spot-comments. E-mail review still welcome as well, of course.
http://llvm-reviews.chandlerc.com/D312 >> One thing I missed before: please don't use iscntrl or isxdigit; >> they're dependent on the current locale (and to be safe, don't use >> isascii either). > > I understand for iscntrl, but isascii appears a lot and the expanded form is > ugly. I guess I'll write my own wrapper. …do I have to? :-D isascii seems pretty obvious as to its intent, and it's specified to be locale-independent. Jordan _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
