Hurcan, Committed in r173071, thanks!
On Jan 19, 2013, at 3:12 PM, Dmitri Gribenko <[email protected]> wrote: > Hello Hurcan, > > On Sat, Jan 19, 2013 at 4:44 AM, Hurcan Solter <[email protected]> wrote: >> Unlike LoadFromCommandLine, LoadFromCompilerInvocation(the one with many >> arguments) causes a crash if Precompilepreamble is set to true because there >> is no FileManager at that point. Two methods are not in sync despite being >> very similar.. > > While this patch LGTM, I think that this function is dead code -- it > is not used by anything in clang. > > Maybe it is better to remove this buggy function that nobody uses? Argyrios? Hurcan uses it presumably ? Let's just keep it for now; at some point I'd really like to do some de-duplication of the ASTUnit load functions, e.g. have an ASTUnitLoadOptions object, or something, encompassing all the different ways to create an ASTUnit and use that with a single load function. > > Dmitri > > -- > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if > (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
