Please move the default out of the switch. Otherwise, looks fine. Thanks for the pch test! On Jan 21, 2013 4:54 AM, "Tim Northover" <[email protected]> wrote:
> Hi Richard, > > > The AST dumper is a bit of a special case. It's intended to be usable > > by running Expr->dump() from a debugger, and consequently it does not > > have access to the ASTContext. > > I thought it might be, which is why I stopped there. > > > If this isn't working out well, how about replacing the IsIEEE flag in > > FloatingLiteralBitfields with a float kind enumeration? > > Now that seems to have worked better; thanks for the suggestion. I've > attached the updated Clang patch, together with its LLVM counterpart > for reference. > > Does it look reasonable to you? > > Tim. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
