Hi, Thanks, committed as r173254.
> I'd like to have "OpenCL" in the name, because these semantics are very much > tied to OpenCL. NativeHalfType was chosen based on discussions with Anton Korobeynikov and John Garvin, in case any other language dialect other than OpenCL will want to use the half type natively: http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-June/022523.html If this was deemed OpenCL specific, no flag would be needed. > How about using ASTContext::getBaseElementType()? Thanks, much cleaner. >Whenever we provide a Fix-It, we need to recover as if the user had written >what we're suggesting. So if we're going to have to actually turn this into a >pointer-to-half type or remove the Fix-It. I deleted the FixIts, they didn't seem to add much value. (and as you said on IRC, you have no strong opinion either way.) Thank, Joey -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
