On Jan 23, 2013, at 1:50 PM, David Blaikie <[email protected]> wrote:
> On Wed, Jan 23, 2013 at 1:12 PM, Ted Kremenek <[email protected]> wrote: >> Author: kremenek >> Date: Wed Jan 23 15:12:49 2013 >> New Revision: 173292 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=173292&view=rev >> Log: >> Add missing null check. Not sure why my tests passed before. > > Did the old code fail if you added an assert(MD) in it? If not, it > sounds like there's a missing test case that might be good to add. (if > it did fail, then somehow you were getting lucky with the way hasAttr > was accessing memory near address zero? Which would be rather > surprising, but if true, there's not really any test to add) Nothing so complicated. The buildbots caught it. Somehow I did something very silly and didn't run the tests correctly.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
