Committed in r173358. Thanks for the review! Michael
On Wed, Jan 23, 2013 at 9:55 PM, Michael Han <[email protected]>wrote: > > On Wed, Jan 23, 2013 at 9:10 PM, Richard Smith <[email protected]>wrote: > >> On Mon, Jan 21, 2013 at 8:12 PM, Michael Han <[email protected]> >> wrote: >> > Attach updated patch with more tests added; also updated all attributes >> to >> > include spelling index when their ast nodes are constructed. >> > OK to commit? >> >> + OS << >> + " case(" << I << ") : {\n" >> >> Remove the parens here. >> >> + // end of the switch statement. >> + OS << "}\n"; >> + // end of the print function. >> >> Please start these comments with a capital letter. >> >> Other than those tiny things, the patch looks good, but the test >> changes seem to be missing from the diff? >> > > Yes the tests were missing from the diff, sorry about that. Attach the > test patch. > > Michael > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
