On 25 January 2013 10:18, Douglas Gregor <[email protected]> wrote: > > On Jan 25, 2013, at 2:32 AM, Nick Lewycky <[email protected]> wrote: > > > This patch fixes a problem where the PCH fails to faithfully represent > the state of Sema, causing it to drop some -Wundefined-internal diagnostics > across PCH boundaries. > > > > While there I noticed that KnownNamespaces was being emitted in an > indeterminate order and added code to sort them deterministically. > > > > Please review! > > (Quoting patches on a phone is awful) > > Serialization bits look good. > > Rather than sorting based on source location, how about just changing > Sema's data structures for both of these to MapVectors? >
Done. Also, I'd rather not renumber the record codes. It's fine to just append to > the list, because order is irrelevant. > Done. Updated patch attached. Please review! Nick > > > > <undefined-internal-pch-1.patch> > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
undefined-internal-pch-2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
