Jordan Rose wrote:
Eek. Should we make this a clang-tblgen error?

Please do :)

On Jan 24, 2013, at 23:31 , Nick Lewycky<[email protected]>  wrote:

Author: nicholas
Date: Fri Jan 25 01:31:12 2013
New Revision: 173429

URL: http://llvm.org/viewvc/llvm-project?rev=173429&view=rev
Log:
Add missing InGroup for this warning.

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
    cfe/trunk/test/Misc/warning-flags.c

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=173429&r1=173428&r2=173429&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Fri Jan 25 01:31:12 
2013
@@ -3276,7 +3276,7 @@
// This should eventually be an error.
def warn_undefined_internal : Warning<
   "%select{function|variable}0 %q1 has internal linkage but is not defined">,
-  DiagGroup<"undefined-internal">;
+  InGroup<DiagGroup<"undefined-internal">>;
def note_used_here : Note<"used here">;

def warn_internal_in_extern_inline : ExtWarn<

Modified: cfe/trunk/test/Misc/warning-flags.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/warning-flags.c?rev=173429&r1=173428&r2=173429&view=diff
==============================================================================
--- cfe/trunk/test/Misc/warning-flags.c (original)
+++ cfe/trunk/test/Misc/warning-flags.c Fri Jan 25 01:31:12 2013
@@ -18,7 +18,7 @@

The list of warnings below should NEVER grow.  It should gradually shrink to 0.

-CHECK: Warnings without flags (146):
+CHECK: Warnings without flags (145):
CHECK-NEXT:   ext_delete_void_ptr_operand
CHECK-NEXT:   ext_enum_friend
CHECK-NEXT:   ext_expected_semi_decl_list
@@ -160,7 +160,6 @@
CHECK-NEXT:   warn_undef_interface
CHECK-NEXT:   warn_undef_interface_suggest
CHECK-NEXT:   warn_undef_protocolref
-CHECK-NEXT:   warn_undefined_internal
CHECK-NEXT:   warn_unknown_method_family
CHECK-NEXT:   warn_use_out_of_scope_declaration
CHECK-NEXT:   warn_weak_identifier_undeclared


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to