Looking great! A couple of minor things, then this LGTM
================
Comment at: lib/AST/ASTDumper.cpp:315-320
@@ +314,8 @@
+// Example of tree and the Indents vector at each level.
+// (A { }
+// |-(B { IT_Child }
+// | `-(C)) { IT_Child, IT_LastChild }
+// `-(D { IT_LastChild }
+// |-(E) { IT_LastChild, IT_Child }
+// `-(F))) { IT_LastChild, IT_LastChild }
+// Type non-last element, last element
----------------
Example still needs updating!
================
Comment at: lib/AST/ASTDumper.cpp:92-93
@@ +91,4 @@
+
+ /// Indicates that more children will be needed at this indent level.
+ /// If true, prevents lastChild() from marking the node as the last child.
+ bool MoreChildren;
----------------
Took me a moment to figure out what this was doing the first time I read this.
Perhaps we could clarify the comment...
Indicates that more children will be needed at this indent level, beyond those
which the current dumping routine knows about. This happens when a node has
multiple collections of children which it wants to dump directly below itself
(for instance, child nodes and attributes).
http://llvm-reviews.chandlerc.com/D281
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
