Yes, this makes sense to me -- so if people split their preprocessing and 
compilation steps (say, for a ccache build), they'll only get the errors from 
the second stage.


================
Comment at: lib/Lex/Lexer.cpp:2836
@@ -2836,1 +2835,3 @@
+  if (!isASCII(*BufferPtr) && !isAllowedIDChar(C) &&
+      (isLexingRawMode() || !PP->isPreprocessedOutput())) {
     // Non-ASCII characters tend to creep into source code unintentionally.
----------------
Do you need the isLexingRawMode() check here? I guess it doesn't matter if we 
drop the non-ASCII characters in that case?


http://llvm-reviews.chandlerc.com/D346
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to