What would be preferred if adding a new statement? Some previous commits seemly 
did not increase CINDEX_VERSION_MINOR or MAJOR.

Thanks!

Wei Pan 

-----Original Message-----
From: Sean Silva [mailto:[email protected]] 
Sent: Wednesday, January 30, 2013 4:46 PM
To: Dmitri Gribenko
Cc: Pan, Wei; Alexey Bataev; clang-dev Developers
Subject: Re: [cfe-dev] [RFC] Captured Statements

On Wed, Jan 30, 2013 at 4:35 PM, Dmitri Gribenko <[email protected]> wrote:
> +  CXCursor_LastStmt                      = CXCursor_ExampleCapturedStmt,
>
> Please bump CINDEX_VERSION_MINOR.

This would violate minor version semantics (at least for most versioning 
schemes; idk which one we officially use). This change is not backwards 
compatible e.g. if a header declares

extern int arr[CXCursor_LastStmt];

then code compiled against this version will read off the end of the array 
which was compiled with a previous minor version.

-- Sean Silva

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to