Hi Tanya,
The patch looks good to me.
Thanks
Guy Benyei
-----Original Message-----
From: [email protected] [mailto:[email protected]]
On Behalf Of Tanya Lattner
Sent: Tuesday, February 05, 2013 20:18
To: [email protected]
Subject: Re: [PATCH] Change how address spaces are mangled
Ping.
Anyone opposed to this?
-Tanya
On Jan 30, 2013, at 2:41 PM, Tanya Lattner <[email protected]> wrote:
> Attached is a patch to change how address spaces are mangled.
>
> Currently, if you specify local, global, or constant OpenCL address spaces
> you get some strange numbers printed in the mangled name which correspond to
> the values in LangAs for opencl_constant, opencl_local, and opencl_global. I
> believe it makes more sense to mangle based upon the real address space
> values that are defined by the target. It makes it easier to understand what
> the address spaces of the arguments to a function really are. I've included a
> test case for both the OpenCL case and if someone used the attribute in C++
> as well.
>
> Please review.
>
> Thanks,
> Tanya
>
> <addrSpaceMangle.patch>_______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
