Thanks, patch committed to revision 174541. Guy Benyei
-----Original Message----- From: Dmitri Gribenko [mailto:[email protected]] Sent: Wednesday, February 06, 2013 22:12 To: Benyei, Guy Cc: [email protected]; [email protected] Subject: Re: [PATCH] RE: [cfe-commits] r173697 - FileCheck'ize and merge tests On Wed, Feb 6, 2013 at 10:05 PM, Benyei, Guy <[email protected]> wrote: > Thanks Dmitri, > I've fixed your comments. > About the test - I'm not exactly sure how to test this change - I'm not sure > if committing a DOS-style file will work right. Any ideas? It should work. Just put a comment explaining that the file is testing that FileCheck is insensitive to newline kind, and other developers should not "fix" the file by converting it to UNIX-style newlines. LGTM with test. Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
