On Fri, Feb 8, 2013 at 2:32 AM, Michael van der Westhuizen
<[email protected]> wrote:
> Please use this corrected patch instead.
>
> Michael
The change looks fine other than it doesn't follow the formatting
conventions of the rest of the CMake code such as 80-col limit, not
starting identifiers with a _, lining up closing ) indented in two
spaces. etc...
Also, I think this breaks the current cache behavior of
LIBCXX_LIBSUPCXX_INCLUDE_PATHS and friends. It would be better to take
the variable name as an argument to the macro. Then access it via
double dereference ${${}}.
- Michael Spencer
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
