LG. Btw, thanks for using phab :)
There's one more thing that would make the review slightly more awesome: use a larger context for the patch (phab automagically exports only a minimal patch in the email, but it allows seeing the whole file while reviewing the patch). git diff -U999999 other-branch svn diff --diff-cmd=diff -x -U999999 (see also: http://llvm.org/docs/Phabricator.html) http://llvm-reviews.chandlerc.com/D385 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
