On Feb 11, 2013, at 8:27 AM, David Blaikie <[email protected]> wrote:
> On Mon, Feb 11, 2013 at 12:35 AM, Bill Wendling <[email protected]> wrote: >> Author: void >> Date: Mon Feb 11 02:35:52 2013 >> New Revision: 174866 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=174866&view=rev >> Log: >> Update test to not fail with attribute groups. >> >> Modified: >> cfe/trunk/test/CodeGen/attr-minsize.cpp >> >> Modified: cfe/trunk/test/CodeGen/attr-minsize.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-minsize.cpp?rev=174866&r1=174865&r2=174866&view=diff >> ============================================================================== >> --- cfe/trunk/test/CodeGen/attr-minsize.cpp (original) >> +++ cfe/trunk/test/CodeGen/attr-minsize.cpp Mon Feb 11 02:35:52 2013 >> @@ -65,11 +65,11 @@ void test5<int>(int arg); >> // Oz: define{{.*}}void @{{.*}}test5 >> // Oz: minsize >> // OTHER: define{{.*}}void @{{.*}}test5 >> -// OTHER-NOT: minsize >> +// OTHER-NOT: define{{.*}}void @{{.*}}test5{{.*}}minsize > > I'm curious - what was the change in IR syntax that caused the first > case to start failing with your attribute changes? (where did > 'minsize' start appearing where it wasn't before) > It started to appear in the attribute groups. So something like this was causing it to be picked up: attributes #0 = { minsize ... } I figured that testing for this case specifically was the best thing to do. Let me know if you would like changes here. :) -bw >> >> template >> void test5<float>(float arg); >> // Oz: define{{.*}}void @{{.*}}test5 >> // Oz: minsize >> // OTHER: define{{.*}}void @{{.*}}test5 >> -// OTHER-NOT: minsize >> +// OTHER-NOT: define{{.*}}void @{{.*}}test5{{.*}}minsize >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
