Hi Dmitri, You're right, the fix is fragile, and it is not the full solution, but it is needed for now to fix the Windows Debug build. I think introducing LLVM's own character classification functions would be better, and it's not too difficult to implement them. Thanks Guy
-----Original Message----- From: Dmitri Gribenko [mailto:[email protected]] Sent: Tuesday, February 12, 2013 20:18 To: Benyei, Guy Cc: Jordan Rose; [email protected]; [email protected] Subject: Re: [PATCH] RE: r174768 - Excise <cctype> from Clang (except clang-tblgen) in favor of CharInfo.h. On Tue, Feb 12, 2013 at 11:50 AM, Benyei, Guy <[email protected]> wrote: > Hi, > Attached a patch for this rather mechanic fix. > Please review. This looks fragile indeed (easy to reintroduce the bugs). Maybe we could introduce wrappers and add an explanation there? Dmitri -- main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
