Please clarify the role of the FunctionDecl in CapturedStmt. Other than that, the patch is fine... but I'd like us to get the parsing patch in at the same time so we have code that does something.
================ Comment at: include/clang/AST/Stmt.h:1962 @@ +1961,3 @@ + /// \brief The implicit outlined function. + FunctionDecl *TheFuncDecl; + ---------------- Interesting. We're actually going to synthesize a FunctionDecl for captured statements? I would have expected that the function would be synthesized entirely in CodeGen, and would never be represented in the AST. Why do we need to represent the function in the AST? ================ Comment at: lib/AST/Stmt.cpp:1075-1078 @@ +1074,6 @@ + // + // ----------------------------------------------------------- + // | CapturedStmt, Init, ..., Init, S, Capture, ..., Capture | + // ----------------^-------------------^---------------------- + // getStoredStmts() getStoredCaptures() + // ---------------- Extra points for the ASCII art :) http://llvm-reviews.chandlerc.com/D370 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
